devops/encoach_frontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in approval-workflows (pull request #154)

Browse Source 
Approval Workflows

Approved-by: Tiago Ribeiro
This commit is contained in:
João Correia
2025-02-20 14:30:24 +00:00
committed by Tiago Ribeiro
parent fec3b51553 b388ee399f
commit 37908423eb
3 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/createWorkflowsOnExamCreation.ts
View File

@@ -72,7 +72,7 @@ export async function createApprovalWorkflowOnExamCreation(examAuthor: string, e
if (totalCount === 0) { // current behaviour: if no workflow was found skip approval process if (totalCount === 0) { // current behaviour: if no workflow was found skip approval process
await db.collection(examModule).updateOne( await db.collection(examModule).updateOne(
{ id: examId }, { id: examId },
{ $set: { id: examId, isDiagnostic: false }}, { $set: { id: examId, access: "private" }},
{ upsert: true } { upsert: true }
); );
} }

6
src/pages/approval-workflows/[id]/edit.tsx
View File

@@ -73,13 +73,9 @@ export default function Home({ user, workflow, workflowEntityApprovers }: Props)
})); }));
const editableWorkflow: EditableApprovalWorkflow = { const editableWorkflow: EditableApprovalWorkflow = {
...workflow,
id: workflow._id?.toString() ?? "", id: workflow._id?.toString() ?? "",
name: workflow.name,
entityId: workflow.entityId,
requester: user.id, // should it change to the editor? requester: user.id, // should it change to the editor?
startDate: workflow.startDate,
modules: workflow.modules,
status: workflow.status,
steps: editableSteps, steps: editableSteps,
}; };

5
src/pages/approval-workflows/[id]/index.tsx
View File

@@ -260,10 +260,7 @@ export default function Home({ user, initialWorkflow, id, workflowAssignees, wor
if (examModule && examId) { if (examModule && examId) {
const exam = await getExamById(examModule, examId.trim()); const exam = await getExamById(examModule, examId.trim());
if (!exam) { if (!exam) {
toast.error( toast.error("Something went wrong while fetching exam!");
"Unknown Exam ID! Please make sure you selected the right module and entered the right exam ID",
{ toastId: "invalid-exam-id" }
);
setViewExamIsLoading(false); setViewExamIsLoading(false);
return; return;
} }