From 8db47a3962482a494efe64a79933de7cf9b3adb6 Mon Sep 17 00:00:00 2001
From: Joao Correia <joao.correia@ecrop.dev>
Date: Sun, 26 Jan 2025 14:07:25 +0000
Subject: [PATCH] Filter out empty select inputs on form submission

---
 src/pages/approval-workflows/[id]/clone.tsx | 13 ++++++++++++-
 src/pages/approval-workflows/[id]/edit.tsx  | 13 ++++++++++++-
 src/pages/approval-workflows/create.tsx     | 11 ++++++++++-
 3 files changed, 34 insertions(+), 3 deletions(-)

diff --git a/src/pages/approval-workflows/[id]/clone.tsx b/src/pages/approval-workflows/[id]/clone.tsx
index 43cf969d..0d12b2f4 100644
--- a/src/pages/approval-workflows/[id]/clone.tsx
+++ b/src/pages/approval-workflows/[id]/clone.tsx
@@ -118,7 +118,18 @@ export default function Home({ user, workflow, userEntitiesWithLabel, userEntiti
 
     const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => {
         e.preventDefault();
-        console.log("Form submitted! Values:", cloneWorkflow);
+    
+        if (!cloneWorkflow) return;
+    
+        const filteredWorkflow = {
+            ...cloneWorkflow,
+            steps: cloneWorkflow.steps.map(step => ({
+                ...step,
+                assignees: step.assignees.filter(assignee => assignee !== null && assignee !== undefined)
+            }))
+        };
+    
+        console.log("Form submitted! Filtered Workflow:", filteredWorkflow);
     };
 
     const onWorkflowChange = (wf: EditableApprovalWorkflow) => {
diff --git a/src/pages/approval-workflows/[id]/edit.tsx b/src/pages/approval-workflows/[id]/edit.tsx
index bae9fb09..bbe35b89 100644
--- a/src/pages/approval-workflows/[id]/edit.tsx
+++ b/src/pages/approval-workflows/[id]/edit.tsx
@@ -82,7 +82,18 @@ export default function Home({ user, workflow, workflowEntityTeachers, workflowE
 
     const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => {
         e.preventDefault();
-        console.log("Form submitted! Values:", updatedWorkflow);
+    
+        if (!updatedWorkflow) return;
+    
+        const filteredWorkflow = {
+            ...updatedWorkflow,
+            steps: updatedWorkflow.steps.map(step => ({
+                ...step,
+                assignees: step.assignees.filter(assignee => assignee !== null && assignee !== undefined)
+            }))
+        };
+    
+        console.log("Form submitted! Filtered Workflow:", filteredWorkflow);
     };
 
     const onWorkflowChange = (wf: EditableApprovalWorkflow) => {
diff --git a/src/pages/approval-workflows/create.tsx b/src/pages/approval-workflows/create.tsx
index ce04fbd8..a0cd86e4 100644
--- a/src/pages/approval-workflows/create.tsx
+++ b/src/pages/approval-workflows/create.tsx
@@ -85,7 +85,16 @@ export default function Home({ user, userEntitiesWithLabel, userEntitiesTeachers
 
     const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => {
         e.preventDefault();
-        console.log("Form submitted! Values:", workflows);
+
+        const filteredWorkflows = workflows.map(workflow => ({
+            ...workflow,
+            steps: workflow.steps.map(step => ({
+                ...step,
+                assignees: step.assignees.filter(assignee => assignee !== null && assignee !== undefined)
+            }))
+        }));
+
+        console.log("Form submitted! Filtered Values:", filteredWorkflows);
     };
 
     const handleAddNewWorkflow = () => {