Minor best practices

This commit is contained in:
Tiago Ribeiro
2023-04-24 09:12:11 +01:00
parent 1adfb7f3d5
commit 5e24abeead
2 changed files with 4 additions and 3 deletions

View File

@@ -24,3 +24,4 @@ export interface Stat {
} }
export type Type = "student" | "teacher" | "admin" | "owner" | "developer"; export type Type = "student" | "teacher" | "admin" | "owner" | "developer";
export const userTypes: Type[] = ["student", "teacher", "admin", "owner", "developer"];

View File

@@ -9,7 +9,7 @@ import {FilterMatchMode, FilterOperator} from "primereact/api";
import useUsers from "@/hooks/useUsers"; import useUsers from "@/hooks/useUsers";
import {DataTable} from "primereact/datatable"; import {DataTable} from "primereact/datatable";
import {Column} from "primereact/column"; import {Column} from "primereact/column";
import _ from "lodash"; import {capitalize} from "lodash";
import {levelCalculator} from "@/resources/level"; import {levelCalculator} from "@/resources/level";
import {Dropdown} from "primereact/dropdown"; import {Dropdown} from "primereact/dropdown";
@@ -45,7 +45,7 @@ export default function Users({user}: {user: User}) {
return ( return (
<Dropdown <Dropdown
value={options.value} value={options.value}
options={userTypes.map((x) => _.capitalize(x))} options={userTypes.map(capitalize)}
onChange={(e) => options.filterApplyCallback(e.value)} onChange={(e) => options.filterApplyCallback(e.value)}
placeholder="Select One" placeholder="Select One"
className="p-column-filter" className="p-column-filter"
@@ -93,7 +93,7 @@ export default function Users({user}: {user: User}) {
filterElement={typeRowFilterTemplate} filterElement={typeRowFilterTemplate}
sortable sortable
header="Type" header="Type"
body={(data: User) => _.capitalize(data.type)} body={(data: User) => capitalize(data.type)}
/> />
</DataTable> </DataTable>
</div> </div>