From 2e5545f1819be52199dcac941549f81d369bb4e3 Mon Sep 17 00:00:00 2001
From: Tiago Ribeiro <tiago.ribeiro@ecrop.dev>
Date: Mon, 2 Dec 2024 17:09:22 +0000
Subject: [PATCH 1/2] Some quick changes to permissions

---
 src/components/Sidebar.tsx               |  6 ++-
 src/pages/(admin)/Lists/CodeList.tsx     | 56 +++++++++++-------------
 src/pages/(admin)/Lists/index.tsx        | 30 +++++++------
 src/pages/entities/[id]/roles/[role].tsx |  4 ++
 src/resources/entityPermissions.ts       | 16 +++++--
 5 files changed, 63 insertions(+), 49 deletions(-)

diff --git a/src/components/Sidebar.tsx b/src/components/Sidebar.tsx
index a420c558..74cc576b 100644
--- a/src/components/Sidebar.tsx
+++ b/src/components/Sidebar.tsx
@@ -27,7 +27,7 @@ import useTicketsListener from "@/hooks/useTicketsListener";
 import { checkAccess, getTypesOfUser } from "@/utils/permissions";
 import usePermissions from "@/hooks/usePermissions";
 import { EntityWithRoles } from "@/interfaces/entity";
-import { useAllowedEntitiesSomePermissions } from "@/hooks/useEntityPermissions";
+import { useAllowedEntities, useAllowedEntitiesSomePermissions } from "@/hooks/useEntityPermissions";
 import { useMemo } from "react";
 
 interface Props {
@@ -95,6 +95,8 @@ export default function Sidebar({
 	const { totalAssignedTickets } = useTicketsListener(user.id);
 	const { permissions } = usePermissions(user.id);
 
+	const entitiesAllowStatistics = useAllowedEntities(user, entities, "view_statistics")
+
 	const entitiesAllowGeneration = useAllowedEntitiesSomePermissions(user, entities, [
 		"generate_reading", "generate_listening", "generate_writing", "generate_speaking", "generate_level"
 	])
@@ -119,7 +121,7 @@ export default function Sidebar({
 				{checkAccess(user, ["student", "teacher", "developer"], permissions, "viewExams") && (
 					<Nav disabled={disableNavigation} Icon={BsFileEarmarkText} label="Practice" path={path} keyPath="/exam" isMinimized={isMinimized} />
 				)}
-				{checkAccess(user, getTypesOfUser(["agent"]), permissions, "viewStats") && (
+				{checkAccess(user, getTypesOfUser(["agent"])) && entitiesAllowStatistics.length > 0 && (
 					<Nav disabled={disableNavigation} Icon={BsGraphUp} label="Stats" path={path} keyPath="/stats" isMinimized={isMinimized} />
 				)}
 				{checkAccess(user, ["developer", "admin", "mastercorporate", "corporate", "teacher", "student"], permissions) && (
diff --git a/src/pages/(admin)/Lists/CodeList.tsx b/src/pages/(admin)/Lists/CodeList.tsx
index d3a5631e..7a5d10b6 100644
--- a/src/pages/(admin)/Lists/CodeList.tsx
+++ b/src/pages/(admin)/Lists/CodeList.tsx
@@ -4,22 +4,22 @@ import Select from "@/components/Low/Select";
 import useCodes from "@/hooks/useCodes";
 import useUser from "@/hooks/useUser";
 import useUsers from "@/hooks/useUsers";
-import {Code, User} from "@/interfaces/user";
-import {USER_TYPE_LABELS} from "@/resources/user";
-import {createColumnHelper, flexRender, getCoreRowModel, useReactTable} from "@tanstack/react-table";
+import { Code, User } from "@/interfaces/user";
+import { USER_TYPE_LABELS } from "@/resources/user";
+import { createColumnHelper, flexRender, getCoreRowModel, useReactTable } from "@tanstack/react-table";
 import axios from "axios";
 import moment from "moment";
-import {useEffect, useState, useMemo} from "react";
-import {BsTrash} from "react-icons/bs";
-import {toast} from "react-toastify";
+import { useEffect, useState, useMemo } from "react";
+import { BsTrash } from "react-icons/bs";
+import { toast } from "react-toastify";
 import ReactDatePicker from "react-datepicker";
 import clsx from "clsx";
-import {checkAccess} from "@/utils/permissions";
+import { checkAccess } from "@/utils/permissions";
 import usePermissions from "@/hooks/usePermissions";
 
 const columnHelper = createColumnHelper<Code>();
 
-const CreatorCell = ({id, users}: {id: string; users: User[]}) => {
+const CreatorCell = ({ id, users }: { id: string; users: User[] }) => {
 	const [creatorUser, setCreatorUser] = useState<User>();
 
 	useEffect(() => {
@@ -34,18 +34,16 @@ const CreatorCell = ({id, users}: {id: string; users: User[]}) => {
 	);
 };
 
-export default function CodeList({user}: {user: User}) {
+export default function CodeList({ user, canDeleteCodes }: { user: User, canDeleteCodes?: boolean }) {
 	const [selectedCodes, setSelectedCodes] = useState<string[]>([]);
 
 	const [filteredCorporate, setFilteredCorporate] = useState<User | undefined>(user?.type === "corporate" ? user : undefined);
 	const [filterAvailability, setFilterAvailability] = useState<"in-use" | "unused">();
 
-	const {permissions} = usePermissions(user?.id || "");
+	const { permissions } = usePermissions(user?.id || "");
 
-	// const [filteredCodes, setFilteredCodes] = useState<Code[]>([]);
-
-	const {users} = useUsers();
-	const {codes, reload} = useCodes(user?.type === "corporate" ? user?.id : undefined);
+	const { users } = useUsers();
+	const { codes, reload } = useCodes(user?.type === "corporate" ? user?.id : undefined);
 
 	const [startDate, setStartDate] = useState<Date | null>(moment("01/01/2023").toDate());
 	const [endDate, setEndDate] = useState<Date | null>(moment().endOf("day").toDate());
@@ -80,6 +78,7 @@ export default function CodeList({user}: {user: User}) {
 	};
 
 	const deleteCodes = async (codes: string[]) => {
+		if (!canDeleteCodes) return
 		if (!confirm(`Are you sure you want to delete these ${codes.length} code(s)?`)) return;
 
 		const params = new URLSearchParams();
@@ -108,6 +107,7 @@ export default function CodeList({user}: {user: User}) {
 	};
 
 	const deleteCode = async (code: Code) => {
+		if (!canDeleteCodes) return
 		if (!confirm(`Are you sure you want to delete this "${code.code}" code?`)) return;
 
 		axios
@@ -129,8 +129,6 @@ export default function CodeList({user}: {user: User}) {
 			.finally(reload);
 	};
 
-	const allowedToDelete = checkAccess(user, ["developer", "admin", "corporate", "mastercorporate"], permissions, "deleteCodes");
-
 	const defaultColumns = [
 		columnHelper.accessor("code", {
 			id: "codeCheckbox",
@@ -183,10 +181,10 @@ export default function CodeList({user}: {user: User}) {
 		{
 			header: "",
 			id: "actions",
-			cell: ({row}: {row: {original: Code}}) => {
+			cell: ({ row }: { row: { original: Code } }) => {
 				return (
 					<div className="flex gap-4">
-						{allowedToDelete && !row.original.userId && (
+						{canDeleteCodes && !row.original.userId && (
 							<div data-tip="Delete" className="cursor-pointer tooltip" onClick={() => deleteCode(row.original)}>
 								<BsTrash className="hover:text-mti-purple-light transition ease-in-out duration-300" />
 							</div>
@@ -215,21 +213,19 @@ export default function CodeList({user}: {user: User}) {
 						value={
 							filteredCorporate
 								? {
-										label: `${
-											filteredCorporate?.type === "corporate"
-												? filteredCorporate.corporateInformation?.companyInformation?.name || filteredCorporate.name
-												: filteredCorporate.name
+									label: `${filteredCorporate?.type === "corporate"
+										? filteredCorporate.corporateInformation?.companyInformation?.name || filteredCorporate.name
+										: filteredCorporate.name
 										} (${USER_TYPE_LABELS[filteredCorporate?.type]})`,
-										value: filteredCorporate.id,
-								  }
+									value: filteredCorporate.id,
+								}
 								: null
 						}
 						options={users
 							.filter((x) => ["admin", "developer", "corporate"].includes(x.type))
 							.map((x) => ({
-								label: `${x.type === "corporate" ? x.corporateInformation?.companyInformation?.name || x.name : x.name} (${
-									USER_TYPE_LABELS[x.type]
-								})`,
+								label: `${x.type === "corporate" ? x.corporateInformation?.companyInformation?.name || x.name : x.name} (${USER_TYPE_LABELS[x.type]
+									})`,
 								value: x.id,
 								user: x,
 							}))}
@@ -240,8 +236,8 @@ export default function CodeList({user}: {user: User}) {
 						placeholder="Availability"
 						isClearable
 						options={[
-							{label: "In Use", value: "in-use"},
-							{label: "Unused", value: "unused"},
+							{ label: "In Use", value: "in-use" },
+							{ label: "Unused", value: "unused" },
 						]}
 						onChange={(value) => setFilterAvailability(value ? (value.value as typeof filterAvailability) : undefined)}
 					/>
@@ -266,7 +262,7 @@ export default function CodeList({user}: {user: User}) {
 						}}
 					/>
 				</div>
-				{allowedToDelete && (
+				{canDeleteCodes && (
 					<div className="flex gap-4 items-center">
 						<span>{selectedCodes.length} code(s) selected</span>
 						<Button
diff --git a/src/pages/(admin)/Lists/index.tsx b/src/pages/(admin)/Lists/index.tsx
index 2557dd9a..6015701b 100644
--- a/src/pages/(admin)/Lists/index.tsx
+++ b/src/pages/(admin)/Lists/index.tsx
@@ -1,5 +1,5 @@
-import {User} from "@/interfaces/user";
-import {Tab, TabGroup, TabList, TabPanel, TabPanels} from "@headlessui/react";
+import { User } from "@/interfaces/user";
+import { Tab, TabGroup, TabList, TabPanel, TabPanels } from "@headlessui/react";
 import clsx from "clsx";
 import CodeList from "./CodeList";
 import DiscountList from "./DiscountList";
@@ -7,10 +7,10 @@ import ExamList from "./ExamList";
 import GroupList from "./GroupList";
 import PackageList from "./PackageList";
 import UserList from "./UserList";
-import {checkAccess} from "@/utils/permissions";
-import {PermissionType} from "@/interfaces/permissions";
+import { checkAccess } from "@/utils/permissions";
+import { PermissionType } from "@/interfaces/permissions";
 import { EntityWithRoles } from "@/interfaces/entity";
-import { useAllowedEntitiesSomePermissions } from "@/hooks/useEntityPermissions";
+import { useAllowedEntities, useAllowedEntitiesSomePermissions } from "@/hooks/useEntityPermissions";
 import { useMemo } from "react";
 
 interface Props {
@@ -19,7 +19,9 @@ interface Props {
 	permissions: PermissionType[];
 }
 
-export default function Lists({user, entities = [], permissions}: Props) {
+export default function Lists({ user, entities = [], permissions }: Props) {
+	const entitiesViewCodes = useAllowedEntities(user, entities, 'view_code_list')
+	const entitiesDeleteCodes = useAllowedEntities(user, entities, 'delete_code')
 	const entitiesViewExams = useAllowedEntitiesSomePermissions(user, entities, [
 		'view_reading', 'view_listening', 'view_writing', 'view_speaking', 'view_level'
 	])
@@ -30,7 +32,7 @@ export default function Lists({user, entities = [], permissions}: Props) {
 		<TabGroup>
 			<TabList className="flex space-x-1 rounded-xl bg-mti-purple-ultralight/40 p-1">
 				<Tab
-					className={({selected}) =>
+					className={({ selected }) =>
 						clsx(
 							"w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-mti-purple-light",
 							"ring-white ring-opacity-60 ring-offset-2 ring-offset-mti-purple-light focus:outline-none focus:ring-2",
@@ -42,7 +44,7 @@ export default function Lists({user, entities = [], permissions}: Props) {
 				</Tab>
 				{canViewExams && (
 					<Tab
-						className={({selected}) =>
+						className={({ selected }) =>
 							clsx(
 								"w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-mti-purple-light",
 								"ring-white ring-opacity-60 ring-offset-2 ring-offset-mti-purple-light focus:outline-none focus:ring-2",
@@ -53,9 +55,9 @@ export default function Lists({user, entities = [], permissions}: Props) {
 						Exam List
 					</Tab>
 				)}
-				{checkAccess(user, ["developer", "admin", "corporate"]) && (
+				{checkAccess(user, ["developer", "admin", "corporate"]) && entitiesViewCodes.length > 0 && (
 					<Tab
-						className={({selected}) =>
+						className={({ selected }) =>
 							clsx(
 								"w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-mti-purple-light",
 								"ring-white ring-opacity-60 ring-offset-2 ring-offset-mti-purple-light focus:outline-none focus:ring-2",
@@ -68,7 +70,7 @@ export default function Lists({user, entities = [], permissions}: Props) {
 				)}
 				{checkAccess(user, ["developer", "admin"]) && (
 					<Tab
-						className={({selected}) =>
+						className={({ selected }) =>
 							clsx(
 								"w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-mti-purple-light",
 								"ring-white ring-opacity-60 ring-offset-2 ring-offset-mti-purple-light focus:outline-none focus:ring-2",
@@ -81,7 +83,7 @@ export default function Lists({user, entities = [], permissions}: Props) {
 				)}
 				{checkAccess(user, ["developer", "admin"]) && (
 					<Tab
-						className={({selected}) =>
+						className={({ selected }) =>
 							clsx(
 								"w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-mti-purple-light",
 								"ring-white ring-opacity-60 ring-offset-2 ring-offset-mti-purple-light focus:outline-none focus:ring-2",
@@ -102,9 +104,9 @@ export default function Lists({user, entities = [], permissions}: Props) {
 						<ExamList user={user} entities={entities} />
 					</TabPanel>
 				)}
-				{checkAccess(user, ["developer", "admin", "corporate", "mastercorporate"], permissions, "viewCodes") && (
+				{checkAccess(user, ["developer", "admin", "corporate", "mastercorporate"]) && entitiesViewCodes.length > 0 && (
 					<TabPanel className="overflow-y-scroll max-h-[600px] rounded-xl scrollbar-hide">
-						<CodeList user={user} />
+						<CodeList user={user} canDeleteCodes={entitiesDeleteCodes.length > 0} />
 					</TabPanel>
 				)}
 				{checkAccess(user, ["developer", "admin"]) && (
diff --git a/src/pages/entities/[id]/roles/[role].tsx b/src/pages/entities/[id]/roles/[role].tsx
index a15480a4..a7a9328d 100644
--- a/src/pages/entities/[id]/roles/[role].tsx
+++ b/src/pages/entities/[id]/roles/[role].tsx
@@ -47,6 +47,8 @@ const USER_MANAGEMENT: PermissionLayout[] = [
 	{ label: "Create Users in Batch", key: "create_user_batch" },
 	{ label: "Create a Single Code", key: "create_code" },
 	{ label: "Create Codes in Batch", key: "create_code_batch" },
+	{ label: "View Code List", key: "view_code_list" },
+	{ label: "Delete Code", key: "delete_code" },
 ]
 
 const EXAM_MANAGEMENT: PermissionLayout[] = [
@@ -65,6 +67,8 @@ const EXAM_MANAGEMENT: PermissionLayout[] = [
 	{ label: "View Level", key: "view_level" },
 	{ label: "Generate Level", key: "generate_level" },
 	{ label: "Delete Level", key: "delete_level" },
+	{ label: "View Statistics", key: "view_statistics" },
+	{ label: "Download Statistics Report", key: "download_statistics_report" }
 ]
 
 const CLASSROOM_MANAGEMENT: PermissionLayout[] = [
diff --git a/src/resources/entityPermissions.ts b/src/resources/entityPermissions.ts
index 8d13da40..e3e3dcc9 100644
--- a/src/resources/entityPermissions.ts
+++ b/src/resources/entityPermissions.ts
@@ -53,14 +53,20 @@ export type RolePermission =
 	"create_user" |
 	"create_user_batch" |
 	"create_code" |
-	"create_code_batch"
+	"create_code_batch" |
+	"view_code_list" |
+	"delete_code" |
+	"view_statistics" |
+	"download_statistics_report"
 
 export const DEFAULT_PERMISSIONS: RolePermission[] = [
 	"view_students",
 	"view_teachers",
 	"view_assignments",
 	"view_classrooms",
-	"view_entity_roles"
+	"view_entity_roles",
+	"view_statistics",
+	"download_statistics_report"
 ]
 
 export const ADMIN_PERMISSIONS: RolePermission[] = [
@@ -118,5 +124,9 @@ export const ADMIN_PERMISSIONS: RolePermission[] = [
 	"create_user",
 	"create_user_batch",
 	"create_code",
-	"create_code_batch"
+	"create_code_batch",
+	"view_code_list",
+	"delete_code",
+	"view_statistics",
+	"download_statistics_report"
 ]

From b6f61c6be174c0429e96bb94dccd63c62668241f Mon Sep 17 00:00:00 2001
From: Tiago Ribeiro <tiago.ribeiro@ecrop.dev>
Date: Mon, 2 Dec 2024 17:12:23 +0000
Subject: [PATCH 2/2] More permissions

---
 src/pages/entities/[id]/roles/[role].tsx | 2 +-
 src/pages/statistical.tsx                | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/pages/entities/[id]/roles/[role].tsx b/src/pages/entities/[id]/roles/[role].tsx
index a7a9328d..64f656bb 100644
--- a/src/pages/entities/[id]/roles/[role].tsx
+++ b/src/pages/entities/[id]/roles/[role].tsx
@@ -68,7 +68,6 @@ const EXAM_MANAGEMENT: PermissionLayout[] = [
 	{ label: "Generate Level", key: "generate_level" },
 	{ label: "Delete Level", key: "delete_level" },
 	{ label: "View Statistics", key: "view_statistics" },
-	{ label: "Download Statistics Report", key: "download_statistics_report" }
 ]
 
 const CLASSROOM_MANAGEMENT: PermissionLayout[] = [
@@ -93,6 +92,7 @@ const ENTITY_MANAGEMENT: PermissionLayout[] = [
 	{ label: "Edit Role Permissions", key: "edit_role_permissions" },
 	{ label: "Assign Role to User", key: "assign_to_role" },
 	{ label: "Delete Entity Role", key: "delete_entity_role" },
+	{ label: "Download Statistics Report", key: "download_statistics_report" }
 ]
 
 const ASSIGNMENT_MANAGEMENT: PermissionLayout[] = [
diff --git a/src/pages/statistical.tsx b/src/pages/statistical.tsx
index 9eabf91a..b674e11c 100644
--- a/src/pages/statistical.tsx
+++ b/src/pages/statistical.tsx
@@ -3,6 +3,7 @@ import Layout from "@/components/High/Layout";
 import Table from "@/components/High/Table";
 import Checkbox from "@/components/Low/Checkbox";
 import Separator from "@/components/Low/Separator";
+import { useAllowedEntities } from "@/hooks/useEntityPermissions";
 import { Session } from "@/hooks/useSessions";
 import { Entity, EntityWithRoles } from "@/interfaces/entity";
 import { Exam } from "@/interfaces/exam";
@@ -84,6 +85,8 @@ export default function Statistical({ user, students, entities, assignments, ses
 	const [selectedEntities, setSelectedEntities] = useState<string[]>([])
 	const [isDownloading, setIsDownloading] = useState(false)
 
+	const entitiesAllowDownload = useAllowedEntities(user, entities, 'download_statistics_report')
+
 	const resetDateRange = () => {
 		const orderedAssignments = orderBy(assignments, ['startDate'], ['asc'])
 		setStartDate(moment(orderedAssignments.shift()?.startDate || "2024-01-01T00:00:01.986Z").toDate())
@@ -297,7 +300,7 @@ export default function Statistical({ user, students, entities, assignments, ses
 						data={sortedData}
 						searchFields={[["student", "name"], ["student", "email"], ["student", "studentID"], ["exams", "id"], ["assignment", "name"]]}
 						searchPlaceholder="Search by student, assignment or exam..."
-						onDownload={downloadExcel}
+						onDownload={entitiesAllowDownload.length > 0 ? downloadExcel : undefined}
 						isDownloadLoading={isDownloading}
 					/>
 				)}