96f419d653
Audit of the admin Configuration section (FAQ Manager, Notification Rules,
Approval Config) surfaced three contract mismatches and one missing schema.
FAQ
* Backend `encoach.faq.category.audience` / `encoach.faq.item.audience`
rejected the `both` and `entity` values emitted by the FAQ Manager
UI. Widened the Selection so the UI's full vocabulary round-trips.
* FAQ item `video_url` was already accepted by the UI but silently
dropped by the controller; now persisted via a new `video_url`
field on `encoach.faq.item` and serialized on list/get responses.
Notification Rules
* Added `days_before`, `frequency`, `channel`, `entity_id` to
`encoach.notification.rule`. These are the exact fields the admin
form collects; prior to this change they were serialized into the
JSON body, ignored by the controller, and omitted from responses,
leaving the Active switch permanently off and the table columns
blank.
* Controller now translates `active` <-> `is_active` both ways so the
new frontend contract and legacy callers coexist. Missing required
fields return HTTP 400 instead of 500.
Approval Workflows
* The controller had been hand-rolling raw SQL against three tables
(`encoach_approval_workflow`, `_stage`, `_request`) that no Odoo
model declared, so the tables never existed. List() was guarded and
returned empty; create() would 500 with "relation does not exist".
* Introduced real ORM models in `encoach_exam_template/models/approval.py`
plus access rights, which auto-provision the tables on -u.
* Rewrote the controller to use ORM, added PATCH, and emitted both
`items` and `results` in the list envelope so the frontend's
PaginatedResponse reader and legacy callers both work. Step
payloads now carry `max_days`, `auto_escalate`, and
`notification_email` end to end.
* Frontend `approvalsService` and `ApprovalWorkflowConfig` updated to
send the full stage shape + `allow_bypass`, tolerate both envelope
keys, and validate at least one approver before submit.
Schema delta applied via `./run.sh -u encoach_exam_template,encoach_lms_api`.
Verified with new `test_config_flows.py`: 24/24 passing. Regression runs
on `test_support_flows.py` (29/29) and `test_training_flows.py` (26/26)
remain green.
Made-with: Cursor
175 lines
6.7 KiB
Python
175 lines
6.7 KiB
Python
import logging
|
|
from odoo import http
|
|
from odoo.http import request
|
|
from odoo.addons.encoach_api.controllers.base import (
|
|
jwt_required, _json_response, _error_response, _get_json_body,
|
|
)
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
def _ser_cat(c):
|
|
return {
|
|
'id': c.id,
|
|
'name': c.name or '',
|
|
'sequence': c.sequence,
|
|
'audience': c.audience or 'all',
|
|
'is_published': c.is_published,
|
|
'item_count': c.item_count or 0,
|
|
}
|
|
|
|
|
|
def _ser_item(i):
|
|
return {
|
|
'id': i.id,
|
|
'category_id': i.category_id.id,
|
|
'category_name': i.category_id.name or '',
|
|
'question': i.question or '',
|
|
'answer': i.answer or '',
|
|
'sequence': i.sequence,
|
|
'audience': i.audience or 'all',
|
|
'is_published': i.is_published,
|
|
'video_url': i.video_url or '',
|
|
}
|
|
|
|
|
|
class FaqController(http.Controller):
|
|
|
|
@http.route('/api/faq/categories', type='http', auth='public', methods=['GET'], csrf=False)
|
|
@jwt_required
|
|
def list_categories(self, **kw):
|
|
try:
|
|
M = request.env['encoach.faq.category'].sudo()
|
|
domain = []
|
|
if kw.get('audience'):
|
|
domain.append(('audience', 'in', [kw['audience'], 'all']))
|
|
recs = M.search(domain, order='sequence, id')
|
|
return _json_response([_ser_cat(r) for r in recs])
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/categories', type='http', auth='public', methods=['POST'], csrf=False)
|
|
@jwt_required
|
|
def create_category(self, **kw):
|
|
try:
|
|
body = _get_json_body()
|
|
vals = {'name': body.get('name', '')}
|
|
if body.get('sequence') is not None:
|
|
vals['sequence'] = int(body['sequence'])
|
|
if body.get('audience'):
|
|
vals['audience'] = body['audience']
|
|
rec = request.env['encoach.faq.category'].sudo().create(vals)
|
|
return _json_response(_ser_cat(rec))
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/categories/<int:cid>', type='http', auth='public', methods=['PATCH', 'PUT'], csrf=False)
|
|
@jwt_required
|
|
def update_category(self, cid, **kw):
|
|
try:
|
|
rec = request.env['encoach.faq.category'].sudo().browse(cid)
|
|
if not rec.exists():
|
|
return _error_response('Not found', 404)
|
|
body = _get_json_body()
|
|
vals = {}
|
|
for k in ('name', 'audience'):
|
|
if k in body:
|
|
vals[k] = body[k]
|
|
if 'sequence' in body:
|
|
vals['sequence'] = int(body['sequence'])
|
|
if 'is_published' in body:
|
|
vals['is_published'] = bool(body['is_published'])
|
|
if vals:
|
|
rec.write(vals)
|
|
return _json_response(_ser_cat(rec))
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/categories/<int:cid>', type='http', auth='public', methods=['DELETE'], csrf=False)
|
|
@jwt_required
|
|
def delete_category(self, cid, **kw):
|
|
try:
|
|
rec = request.env['encoach.faq.category'].sudo().browse(cid)
|
|
if rec.exists():
|
|
rec.unlink()
|
|
return _json_response({'success': True})
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
# ── Items ────────────────────────────────────────────────────────
|
|
|
|
@http.route('/api/faq/items', type='http', auth='public', methods=['GET'], csrf=False)
|
|
@jwt_required
|
|
def list_items(self, **kw):
|
|
try:
|
|
M = request.env['encoach.faq.item'].sudo()
|
|
domain = []
|
|
if kw.get('category_id'):
|
|
domain.append(('category_id', '=', int(kw['category_id'])))
|
|
if kw.get('audience'):
|
|
domain.append(('audience', 'in', [kw['audience'], 'all']))
|
|
if kw.get('search'):
|
|
domain.append(('question', 'ilike', kw['search']))
|
|
recs = M.search(domain, order='sequence, id')
|
|
return _json_response([_ser_item(r) for r in recs])
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/items', type='http', auth='public', methods=['POST'], csrf=False)
|
|
@jwt_required
|
|
def create_item(self, **kw):
|
|
try:
|
|
body = _get_json_body()
|
|
vals = {
|
|
'question': body.get('question', ''),
|
|
'answer': body.get('answer', ''),
|
|
'category_id': int(body.get('category_id', 0)),
|
|
}
|
|
if body.get('sequence') is not None:
|
|
vals['sequence'] = int(body['sequence'])
|
|
if body.get('audience'):
|
|
vals['audience'] = body['audience']
|
|
if body.get('video_url') is not None:
|
|
vals['video_url'] = body['video_url'] or False
|
|
rec = request.env['encoach.faq.item'].sudo().create(vals)
|
|
return _json_response(_ser_item(rec))
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/items/<int:iid>', type='http', auth='public', methods=['PATCH', 'PUT'], csrf=False)
|
|
@jwt_required
|
|
def update_item(self, iid, **kw):
|
|
try:
|
|
rec = request.env['encoach.faq.item'].sudo().browse(iid)
|
|
if not rec.exists():
|
|
return _error_response('Not found', 404)
|
|
body = _get_json_body()
|
|
vals = {}
|
|
for k in ('question', 'answer', 'audience'):
|
|
if k in body:
|
|
vals[k] = body[k]
|
|
if 'category_id' in body:
|
|
vals['category_id'] = int(body['category_id'])
|
|
if 'sequence' in body:
|
|
vals['sequence'] = int(body['sequence'])
|
|
if 'is_published' in body:
|
|
vals['is_published'] = bool(body['is_published'])
|
|
if 'video_url' in body:
|
|
vals['video_url'] = body['video_url'] or False
|
|
if vals:
|
|
rec.write(vals)
|
|
return _json_response(_ser_item(rec))
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|
|
|
|
@http.route('/api/faq/items/<int:iid>', type='http', auth='public', methods=['DELETE'], csrf=False)
|
|
@jwt_required
|
|
def delete_item(self, iid, **kw):
|
|
try:
|
|
rec = request.env['encoach.faq.item'].sudo().browse(iid)
|
|
if rec.exists():
|
|
rec.unlink()
|
|
return _json_response({'success': True})
|
|
except Exception as e:
|
|
return _error_response(str(e), 500)
|