96f419d653
Audit of the admin Configuration section (FAQ Manager, Notification Rules,
Approval Config) surfaced three contract mismatches and one missing schema.
FAQ
* Backend `encoach.faq.category.audience` / `encoach.faq.item.audience`
rejected the `both` and `entity` values emitted by the FAQ Manager
UI. Widened the Selection so the UI's full vocabulary round-trips.
* FAQ item `video_url` was already accepted by the UI but silently
dropped by the controller; now persisted via a new `video_url`
field on `encoach.faq.item` and serialized on list/get responses.
Notification Rules
* Added `days_before`, `frequency`, `channel`, `entity_id` to
`encoach.notification.rule`. These are the exact fields the admin
form collects; prior to this change they were serialized into the
JSON body, ignored by the controller, and omitted from responses,
leaving the Active switch permanently off and the table columns
blank.
* Controller now translates `active` <-> `is_active` both ways so the
new frontend contract and legacy callers coexist. Missing required
fields return HTTP 400 instead of 500.
Approval Workflows
* The controller had been hand-rolling raw SQL against three tables
(`encoach_approval_workflow`, `_stage`, `_request`) that no Odoo
model declared, so the tables never existed. List() was guarded and
returned empty; create() would 500 with "relation does not exist".
* Introduced real ORM models in `encoach_exam_template/models/approval.py`
plus access rights, which auto-provision the tables on -u.
* Rewrote the controller to use ORM, added PATCH, and emitted both
`items` and `results` in the list envelope so the frontend's
PaginatedResponse reader and legacy callers both work. Step
payloads now carry `max_days`, `auto_escalate`, and
`notification_email` end to end.
* Frontend `approvalsService` and `ApprovalWorkflowConfig` updated to
send the full stage shape + `allow_bypass`, tolerate both envelope
keys, and validate at least one approver before submit.
Schema delta applied via `./run.sh -u encoach_exam_template,encoach_lms_api`.
Verified with new `test_config_flows.py`: 24/24 passing. Regression runs
on `test_support_flows.py` (29/29) and `test_training_flows.py` (26/26)
remain green.
Made-with: Cursor
72 lines
2.5 KiB
Python
72 lines
2.5 KiB
Python
from odoo import models, fields
|
|
|
|
|
|
class EncoachNotification(models.Model):
|
|
_name = 'encoach.notification'
|
|
_description = 'Notification'
|
|
_order = 'create_date desc'
|
|
|
|
user_id = fields.Many2one('res.users', required=True, ondelete='cascade', index=True)
|
|
title = fields.Char(required=True)
|
|
message = fields.Text()
|
|
type = fields.Selection([
|
|
('info', 'Info'),
|
|
('warning', 'Warning'),
|
|
('success', 'Success'),
|
|
('error', 'Error'),
|
|
], default='info')
|
|
is_read = fields.Boolean(default=False)
|
|
read_at = fields.Datetime()
|
|
reference_model = fields.Char()
|
|
reference_id = fields.Integer()
|
|
|
|
|
|
class EncoachNotificationRule(models.Model):
|
|
_name = 'encoach.notification.rule'
|
|
_description = 'Notification Rule'
|
|
|
|
name = fields.Char(required=True)
|
|
event_type = fields.Char(required=True, help='e.g. deadline, chapter_unlock, '
|
|
'result_release, assignment, exam')
|
|
template = fields.Text()
|
|
is_active = fields.Boolean(default=True)
|
|
recipients = fields.Selection([
|
|
('all', 'All Users'),
|
|
('students', 'Students Only'),
|
|
('teachers', 'Teachers Only'),
|
|
('admins', 'Admins Only'),
|
|
], default='all')
|
|
channels = fields.Char(help='Legacy: comma-separated email,push,in_app. '
|
|
'New code should use `channel` instead.')
|
|
|
|
# New fields aligned with the admin Configuration UI (NotificationRules page)
|
|
days_before = fields.Integer(default=1,
|
|
help='Lead time in days before the event fires.')
|
|
frequency = fields.Selection([
|
|
('once', 'Once'),
|
|
('daily', 'Daily'),
|
|
('custom', 'Custom schedule'),
|
|
], default='once')
|
|
channel = fields.Selection([
|
|
('in_app', 'In-App'),
|
|
('email', 'Email'),
|
|
('both', 'Both'),
|
|
], default='in_app')
|
|
entity_id = fields.Many2one('encoach.entity', ondelete='set null')
|
|
|
|
|
|
class EncoachNotificationPreference(models.Model):
|
|
_name = 'encoach.notification.preference'
|
|
_description = 'Notification Preference'
|
|
_rec_name = 'user_id'
|
|
|
|
user_id = fields.Many2one('res.users', required=True, ondelete='cascade', index=True)
|
|
email_enabled = fields.Boolean(default=True)
|
|
push_enabled = fields.Boolean(default=True)
|
|
in_app_enabled = fields.Boolean(default=True)
|
|
digest_frequency = fields.Selection([
|
|
('realtime', 'Real-time'),
|
|
('daily', 'Daily'),
|
|
('weekly', 'Weekly'),
|
|
], default='realtime')
|